Fix three skill template bugs in start and submit-for-review#47
Merged
Conversation
Member
Author
Review SummaryVerdict: APPROVE Findings
|
This was referenced Apr 7, 2026
Merged
Merged
Merged
sebastientaggart
added a commit
that referenced
this pull request
Apr 8, 2026
…rt-submit Fix three skill template bugs in start and submit-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three bugs in the skill templates surfaced during a real /start → /submit-for-review cycle:
HUMAN GATE silently skipped in preview/plan modes —
skills/start.mdStep 2 now notes the friendly text question is required regardless of harness mode; the harness's approval UI mediates the wait but does not replace the question.gh issue developignoredBRANCH_DEV— both invocations (Case A Step 4 and Case B Step 3) now pass--base {{BRANCH_DEV}}when set, so feature branches are cut from dev instead of the GitHub default (main). Includes a note explaining why the flag is required (gh reads base from the API, not local state).PR body inherited agent-attribution footer —
skills/submit-for-review.mdnow has an explicit "PR body content rules" callout forbidding attribution footers, generation markers, and Co-Authored-By trailers in both PR bodies and commit messages.All four adapter outputs (.claude, .cursor, .agents, .gemini) regenerated via sync.sh.
Issue #46